Templates refactoring & content update
7 unresolved threads
7 unresolved threads
Enhanced readability on templates, updated frontpage & contact information
Merge request reports
Activity
Filter activity
requested review from @maximilian.moser
assigned to @maximilian.moser
7 Invenio is free software; you can redistribute it and/or modify it 8 under the terms of the MIT License; see LICENSE file for more details. 5 Invenio is free software; you can redistribute it and/or modify it 6 under the terms of the MIT License; see LICENSE file for more details. 9 7 #} 10 {%- extends config.BASE_TEMPLATE %} 11 8 12 {%- block page_header %} 13 {% include config.THEME_HEADER_TEMPLATE %} 14 {%- endblock %} 9 {%- extends config.BASE_TEMPLATE %} 15 10 16 11 {%- block page_hero %} 17 <section id="hero" class="contact" style="flex-shrink: 0;"> 18 </section> 12 <section id="hero" class="contact" style="flex-shrink: 0;"></section> -
just as a note; we should remove inline styles, as they're really bad practice... also, i think they don't even work on our site anymore, because we've set the CSP header to disallow inline styles
we can address this in a follow-up MR
Edited by Moser, Maximilian
19 13 {%- endblock page_hero %} 20 14 21 15 {%- block page_body %} 22 <section class="ui container"> 16 17 <section class="ui container"> 23 18 <h1>Contact</h1> 24 19 <p> 25 <span class="bold">Center for Research Data Management</span><br/> 26 Favoritenstraße 16/DG<br/> 27 1030 Wien<br/> 28 Austria<br/> 29 <i class="icon globe"></i> <a href="https://www.tuwien.at/en/research/rti-support/research-data">https://www.tuwien.at/en/research/rti-support/research-data</a><br/> 30 <i class="icon at"></i> <a href="mailto:{{ config.THEME_TUW_CONTACT_EMAIL }}?subject=About {{ config.THEME_SITENAME }}...">{{ config.THEME_TUW_CONTACT_EMAIL }}</a> 20 <span class="bold">Center for Research Data Management</span> 21 <br/> -
maybe we could go with more semantic nested tags to represent the address lines, rather than with a set of
<br />sthis can be addressed in a follow-up MR
Edited by Moser, Maximilian
31 <br/> 32 <br/> 33 In case of technical issues, you can contact the Service Center of TU.it: 34 <br/> 35 <a href="https://support.tuwien.ac.at/assystnet">Ticketsystem-Online-Portal</a> 36 <br/> 37 Hotline 01 588 01 42002 38 <br/> 39 <a href="mailto:help@it.tuwien.ac.at">help@it.tuwien.ac.at</a> 40 <br/> 31 41 </p> 32 </section> 33 {%- endblock page_body %} 34 35 {%- block page_footer %} 36 {% include config.THEME_FOOTER_TEMPLATE %} -
were the
THEME_FOOTER_TEMPLATEandTHEME_TRACKINGCODE_TEMPLATEnot required? are these the ones that were already defined in a parent template, and unnecessarily duplicated here?Edited by Moser, Maximilian
7 Invenio is free software; you can redistribute it and/or modify it 8 under the terms of the MIT License; see LICENSE file for more details. 5 Invenio is free software; you can redistribute it and/or modify it 6 under the terms of the MIT License; see LICENSE file for more details. 9 7 #} 10 {%- extends config.BASE_TEMPLATE %} 11 8 12 {%- block page_header %} 13 {% include config.THEME_HEADER_TEMPLATE %} 14 {%- endblock %} 9 {%- extends config.BASE_TEMPLATE %} 15 10 16 11 {%- block page_hero %} 17 <section id="hero" class="policies" style="flex-shrink: 0;"> 18 </section> 12 <section id="hero" class="policies" style="flex-shrink: 0;"></section> -
as mentioned above, we should remove the inline styles in a follow-up MR
Edited by Moser, Maximilian
24 <h1>{{ _("Policies") }}</h1> 25 <div class="filelist"> 26 <a class="filelist-item" target="_blank" href="{{ rdm_policy_link }}"> 27 <img src="{{ url_for("static", filename="images/pdf.webp") }}"/ > 28 <span>{{ _("TU Wien Policy for Research Data Management") }}</span> 29 </a> 30 <a class="filelist-item disabled" href="#"> 31 <img src="{{ url_for("static", filename="images/pdf.webp") }}" /> 32 <span>{{ _("Policy for Repository '%(sitename)s' (coming soon)", sitename=config.THEME_SITENAME) }}</span> 33 </a> 34 </div> 35 </section> 36 {%- endblock page_body %} 37 16 38 {%- block page_footer %} 39 {% include config.THEME_FOOTER_TEMPLATE %} 18 <div class="supportlogo"> 19 <a href="https://inveniosoftware.org/products/rdm/"> 20 <p>powered by</p> 21 <img src="/static/images/footer-logos/rdmlogo.webp" alt="{{ _("Logo of Invenio RDM") }}" /> 22 </a> 23 </div> 24 <div class="supportlogo"> 25 <a href="https://forschungsdaten.at/fda/"> 26 <p>enabled by</p> 27 <img src="/static/images/footer-logos/fair-data-austria.webp" alt="{{ _("Logo of the 'FAIR Data Austria' project") }}" /> 28 </a> 29 </div> 19 <div class="supportlogo"> 20 <a href="https://inveniosoftware.org/products/rdm/"> 21 <p>powered by</p> 22 <img src="/static/images/footer-logos/rdmlogo.webp" alt="{{ _("Logo of Invenio RDM") }}" /> 22 <img src="/static/images/footer-logos/rdmlogo.webp" alt="{{ _("Logo of Invenio RDM") }}" /> 23 </a> 24 </div> 25 <div class="supportlogo"> 26 <a href="https://forschungsdaten.at/fda/"> 27 <p>enabled by</p> 28 <img src="/static/images/footer-logos/fair-data-austria.webp" alt="{{ _("Logo of the 'FAIR Data Austria' project") }}" /> 29 </a> 30 </div> 30 31 </div> 31 32 <nav class="footer"> 32 <a href="{{policies_url}}">{{ _("Policies") }}</a> 33 <a href="{{terms_of_use_url}}" target="_blank">{{ _("Terms of Use") }}</a> 34 <a href="{{privacy_statement_url}}" target="_blank">{{ _("Data Protection Declaration") }}</a> 35 <a href="{{contact}}">{{ _("Contact") }}</a> 33 <a href="{{policies_url}}">{{ _("Policies") }}</a>
Please register or sign in to reply